Skip to content

disable survey contribution #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

disable survey contribution #1150

merged 1 commit into from
Jul 5, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

We need to disable the survey notification for now.

Change description

Remove binding of survey frontend contribution.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested a review from kittaakos July 5, 2022 14:54
kittaakos
kittaakos approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. Thank you!

I built the IDE2 locally, ran localStorage.clear() in the console, reloaded the window, and could not see the survey notification.

@AlbyIanna AlbyIanna merged commit 0ce065e into main Jul 5, 2022
@AlbyIanna AlbyIanna deleted the disable-survey-contribution branch July 5, 2022 15:44
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlbyIanna @kittaakos @per1234